Hi,
Great job!
On Mon, Jul 18, 2011 at 11:29 AM, Cyril Hrubis metan@ucw.cz wrote:
Hi! As you may see I've fixed the generate branch to compile (that is good).
Thanks for fixing the rest of the library. Were there bigger problems in core?
But still there are some problems that arised and needs to be fixed:
- The GP_SET_BITS() used in GP_PutPixel_Raw doesn't work correctly
unless you explicitly cast the result from GP_PIXEL_ADDR_32BPP() to (uint32_t*) (and same for each pixel > 8BPP).
Uhh ... right. GP_SET_BITS is meant to be general and respects the parameter type size. Thanks.
- The GP_PutPixel and GP_GetPixel now uses transformation flags for default
but the rest of the library doesn't (eg. gfx part). Should we simply rename GP_TLine to GP_Line and GP_Line to GP_Line_Raw and so?
I would be in favor of that. The user should not need it and there are always the Raw variants.
Thanks again, Tomas